----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45658/#review126942 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java (line 1001) <https://reviews.apache.org/r/45658/#comment190016> Missing toLowerCase() here? Actually it might be better to do these checks using PrimitiveTypeInfo/TypeGrouping, which you should be able to get from ExprNodeDesc. - Jason Dere On April 3, 2016, 6:09 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45658/ > ----------------------------------------------------------- > > (Updated April 3, 2016, 6:09 p.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-13373 > https://issues.apache.org/jira/browse/HIVE-13373 > > > Repository: hive-git > > > Description > ------- > > Currently integer & tinyint/bigint comparisons happen in double. They should > happen in integer instead. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > 45dfd27 > ql/src/test/queries/clientpositive/type_widening.q b504cf9 > ql/src/test/results/clientpositive/infer_const_type.q.out bd42f05 > ql/src/test/results/clientpositive/spark/vectorization_0.q.out aeb6fb8 > ql/src/test/results/clientpositive/spark/vectorization_short_regress.q.out > e9fb1e8 > ql/src/test/results/clientpositive/tez/vectorization_0.q.out c790578 > ql/src/test/results/clientpositive/tez/vectorization_short_regress.q.out > 32fdef6 > ql/src/test/results/clientpositive/type_widening.q.out 84e53f8 > ql/src/test/results/clientpositive/vectorization_0.q.out 53dffed > ql/src/test/results/clientpositive/vectorization_short_regress.q.out > 91c10f0 > > Diff: https://reviews.apache.org/r/45658/diff/ > > > Testing > ------- > > New test & regression suite. > > > Thanks, > > Ashutosh Chauhan > >
