> On April 14, 2016, 7:26 a.m., Szehon Ho wrote: > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java, > > line 155 > > <https://reviews.apache.org/r/45733/diff/2/?file=1327498#file1327498line155> > > > > Was a task removed from the display? > > Rajat Khandelwal wrote: > No, but there is some change in when the tasks are updated in the query > display. Each task updates the task display whenever there's a status change. > The query display needs to be registered with the task. Earlier they were > getting set through the `QueryPlan` constructer, and a lot of tasks were > getting missed in the query display. Now they are registered by the driver in > the execute function. Because of this, all the important tasks have query > displays, and some not-so important tasks are left out, which is fine. > > Secondly, this was already 1 before my last change. Now it's again 1, so > shouldn't be an issue.
Not updating Fetch tasks in the query display now. That's why it's 1 again. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45733/#review128822 ----------------------------------------------------------- On April 19, 2016, 1:33 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45733/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 1:33 p.m.) > > > Review request for hive, Amareshwari Sriramadasu and Szehon Ho. > > > Bugs: HIVE-13421 > https://issues.apache.org/jira/browse/HIVE-13421 > > > Repository: hive-git > > > Description > ------- > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/session/TestQueryDisplay.java > 98581e0e09c20b30eafd6aae99068fddf1596d8e > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > 65744ac866ecd1bee885370394cf720631586ed2 > ql/src/java/org/apache/hadoop/hive/ql/QueryDisplay.java > d582bc063fc150002a01d63451ae6632fca29ac1 > ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java > ef0923d555ba662b4ed30ef45a3d72760cdfad52 > ql/src/java/org/apache/hadoop/hive/ql/exec/ConditionalTask.java > c96c8135a344049e57167559c4d760b876a42ca5 > ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java > 6c677f5bbae024b503594238e59f9fbf6ba283cf > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java > d164859219896d88c42a69e56f621cb08012f633 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java > 1b296b9986907d983a754f9957f2cbe4f7583ae5 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java > 698b13d66f100618aab3c3ee2cbf3c3df8477afe > > Diff: https://reviews.apache.org/r/45733/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
