> On April 22, 2016, 6:06 p.m., pengcheng xiong wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 1997 > > <https://reviews.apache.org/r/45274/diff/3/?file=1352133#file1352133line1997> > > > > IMHO, this is a little bit verbose. Now we have 8 branches for 2^3 > > combinations... For example, The options for relySpec are only "rely" and > > "noreply", we can make them keywords but not reserved ones. Then we have > > "^(TOK_RELY) replyOption ^(TOK_DISABLE) disableOption ^(TOK_NOVALIDATE)" > > noValidateOption". The parser can try to match the grammer automatically > > and we do not need TOK_INVALID_KEY_SPEC any more.
Pengcheng, that makes a lot of sense and avoids a lot of complexity in the Parser's generated state machine. I am in the process of uploading the patch but can you look at the grammar for HiveParser in Revision 2. The changes are the same as that except that we make all the KEYWORDs non-reserved - Hari Sankar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45274/#review130137 ----------------------------------------------------------- On April 20, 2016, 12:20 a.m., Hari Sankar Sivarama Subramaniyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45274/ > ----------------------------------------------------------- > > (Updated April 20, 2016, 12:20 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > Support primary keys/foreign keys constraint as part of create table command > in Hive > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java f091f67 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java b26f09d > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4c9acce > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 19342a8 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 50c53db > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 549d24f > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 96df189 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 03b4d8b > > Diff: https://reviews.apache.org/r/45274/diff/ > > > Testing > ------- > > Local testing done > > > Thanks, > > Hari Sankar Sivarama Subramaniyan > >
