----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46597/#review131248 -----------------------------------------------------------
Minor comment which should be fixed. Regarding exceptions - the Java security exception is not an IOException. I guess we're tied to AccessControlExceptions coming from the Hadoop RPC layer. For the authorization checks we're doing though - I think we're free to decide the exception type. I think non IOException, and a specific one defined by LLAP or a standard Java exception would be better. We can change this later if it becomes a problem. Multiple tokens - still don't see the need. EOD, the patch looks good - but contains more changes and more functionality than I think is required. llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java (line 196) <https://reviews.apache.org/r/46597/#comment195150> This can send in a real cluster name, instead of leaving it null ? - Siddharth Seth On April 26, 2016, 12:58 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46597/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 12:58 a.m.) > > > Review request for hive and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA > > > Diffs > ----- > > > llap-common/src/gen/protobuf/gen-java/org/apache/hadoop/hive/llap/daemon/rpc/LlapDaemonProtocolProtos.java > 4ab7b32 > llap-common/src/java/org/apache/hadoop/hive/llap/DaemonId.java PRE-CREATION > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenIdentifier.java > 23980d0 > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenProvider.java > 2e99a28 > llap-common/src/protobuf/LlapDaemonProtocol.proto 944c96c > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/ContainerRunner.java > fc29371 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > e80fb15 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java > 33b41e8 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapProtocolServerImpl.java > e99e689 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTokenChecker.java > PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryInfo.java > 64c2b58 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java > 14657e6 > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/Scheduler.java > 26c8e55 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java > 57dd828 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSecurityHelper.java > 76ba225 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > 8c7a539 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java > 610f266 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java > 4d05c35 > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java > a65bf5c > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapTokenChecker.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 8aca779 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java 3ea5ef9 > > Diff: https://reviews.apache.org/r/46597/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
