----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47040/#review132054 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 497) <https://reviews.apache.org/r/47040/#comment196117> Why is scheduler configured in Driver and not in the class that calls like ExecDriver? ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java (line 1) <https://reviews.apache.org/r/47040/#comment196108> Apache license header must be in this file. ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java (lines 9 - 11) <https://reviews.apache.org/r/47040/#comment196109> Remove this code, and add a better explanation of what the class does. ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java (line 14) <https://reviews.apache.org/r/47040/#comment196111> Could you explain in a comment why we do not map if impersonation is on? ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java (line 15) <https://reviews.apache.org/r/47040/#comment196110> What if configuration is null? Should we return false to avoid exceptions? ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java (line 21) <https://reviews.apache.org/r/47040/#comment196114> This may fail if impersonation is enabled. Does this error gives enough information to the user? ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java (line 24) <https://reviews.apache.org/r/47040/#comment196116> There is another validation on Hadoop23Shims.refreshDefaultQueue(). Why don't we have that one too here? shims/common/src/main/java/org/apache/hadoop/fs/FileSystemWatcher.java (line 1) <https://reviews.apache.org/r/47040/#comment196118> Apache license here. shims/common/src/main/java/org/apache/hadoop/fs/FileSystemWatcher.java (line 16) <https://reviews.apache.org/r/47040/#comment196119> Comments about what this class does. More comments on each method. shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java (line 102) <https://reviews.apache.org/r/47040/#comment196121> if FILE_SYSTEM_WATCHER maybe null, then this may fail too - Sergio Pena On May 5, 2016, 8:06 p.m., Reuben Kuhnert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47040/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 8:06 p.m.) > > > Review request for hive, Lenni Kuff, Mohit Sabharwal, and Sergio Pena. > > > Bugs: HIVE-13696 > https://issues.apache.org/jira/browse/HIVE-13696 > > > Repository: hive-git > > > Description > ------- > > Ensure that jobs sent to yarn with impersonation off are correctly routed to > the proper queue based on fair-scheduler.xml. Validate that jobs can only be > sent to queues authorized for the user. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > 6a610cbcb1deb7f7f55bb8aff58020b057454b31 > ql/src/java/org/apache/hadoop/hive/ql/session/YarnFairScheduling.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > a0015ebc655931f241b28c53fbb94cfe172841b1 > shims/common/src/main/java/org/apache/hadoop/fs/FileSystemWatcher.java > PRE-CREATION > shims/common/src/main/java/org/apache/hadoop/hive/shims/SchedulerShim.java > 63803b8b0752745bd2fedaccc5d100befd97093b > > shims/scheduler/src/main/java/org/apache/hadoop/hive/schshim/FairSchedulerShim.java > 372244dc3c989d2a3ae2eb2bfb8cd0a235705e18 > > Diff: https://reviews.apache.org/r/47040/diff/ > > > Testing > ------- > > > Thanks, > > Reuben Kuhnert > >
