----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47242/#review132821 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 3074) <https://reviews.apache.org/r/47242/#comment197074> Any reason why remove the static? I think the newly added method can be static too. ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 3168) <https://reviews.apache.org/r/47242/#comment197073> I think FileNotFoundException is not needed here. - Rui Li On May 11, 2016, 4:36 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47242/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 4:36 p.m.) > > > Review request for hive and Rui Li. > > > Bugs: HIVE-13726 > https://issues.apache.org/jira/browse/HIVE-13726 > > > Repository: hive-git > > > Description > ------- > > For insert overwrite significant amount might be spent in deleting existing > files. This patch parallelizes this task. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 71c9188 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java dd14124 > > Diff: https://reviews.apache.org/r/47242/diff/ > > > Testing > ------- > > existing regression tests. No change in functionality. > > > Thanks, > > Ashutosh Chauhan > >
