----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47392/#review133552 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java (line 253) <https://reviews.apache.org/r/47392/#comment198048> Its still needed. Because that call in turn calls StatsUtils::collectStatistics() which ultimately calls Hive.getAggrColStatsFor() which does no checks for state of stats and rightly so. Since, till now we were using Stats mostly for planning and even if they are stale, its ok to use them. But here we are using it to remove filters altogether which has potentially to give wrong results if stats are not up to date. - Ashutosh Chauhan On May 15, 2016, 5:48 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47392/ > ----------------------------------------------------------- > > (Updated May 15, 2016, 5:48 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-13269 > https://issues.apache.org/jira/browse/HIVE-13269 > > > Repository: hive-git > > > Description > ------- > > HIVE-13269 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 541af577e85ff37b509d06ba843911e765383adf > data/conf/perf-reg/hive-site.xml 9e929fcdcb1fecc7ff8b9d40dd4e25fd92850616 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java > 2f309f3de6acfac09b7b0d84cbb9d4275e317aeb > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveReduceExpressionsWithStatsRule.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > de6a053a5b299ee39ec9af865d077a886497189f > ql/src/test/queries/clientpositive/remove_exprs_stats.q PRE-CREATION > ql/src/test/results/clientpositive/perf/query88.q.out > e3f69d3b4739ebfb692c3b8a5aa343b539bb0906 > ql/src/test/results/clientpositive/remove_exprs_stats.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/47392/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
