> On May 31, 2016, 11:09 p.m., Siddharth Seth wrote: > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java, > > line 350 > > <https://reviews.apache.org/r/47563/diff/3/?file=1399778#file1399778line350> > > > > Is a signature always expected ? If so, may as well convert this to a > > precondition. > > Otherwise, in what case will it not be expected ? > > Sergey Shelukhin wrote: > Unsecure case?
A comnment in the code mentions that TaskSpec will be used for the unsecure case. If we're using the vertexBinary for unsecure - that's even better, since it stays consistent. (There's a comment indicating the same somewhere else in the review) - Siddharth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47563/#review135706 ----------------------------------------------------------- On June 1, 2016, 9:23 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47563/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 9:23 p.m.) > > > Review request for hive, Jason Dere and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see JIRA. Please ignore the first iteration, RB doesn't allow base patches on > submit > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b2e6b6f > llap-client/src/java/org/apache/hadoop/hive/llap/SubmitWorkInfo.java > 6704294 > > llap-client/src/java/org/apache/hadoop/hive/llap/coordinator/LlapCoordinator.java > PRE-CREATION > llap-client/src/java/org/apache/hadoop/hive/llap/io/api/LlapProxy.java > 6c2618b > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java > af889b6 > > llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClientImpl.java > PRE-CREATION > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapSigner.java > 478a40a > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapSignerImpl.java > PRE-CREATION > > llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenLocalClient.java > PRE-CREATION > > llap-common/src/java/org/apache/hadoop/hive/llap/security/SecretManager.java > 5aa4b84 > > llap-common/src/java/org/apache/hadoop/hive/llap/security/SigningSecretManager.java > 067a98e > llap-common/src/java/org/apache/hadoop/hive/llap/tez/Converters.java > e43b72b > llap-common/src/test/org/apache/hadoop/hive/llap/tez/TestConverters.java > 1df6df0 > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java > 4306c22 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > d439c07 > > llap-server/src/java/org/apache/hadoop/hive/llap/security/LlapSignerImpl.java > 4174593 > > llap-server/src/test/org/apache/hadoop/hive/llap/security/TestLlapSignerImpl.java > 0420225 > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java > 026df3b > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java d04cfa3 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 140dbda > service/src/java/org/apache/hive/service/server/HiveServer2.java d61edf5 > > Diff: https://reviews.apache.org/r/47563/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
