> On June 3, 2016, 7:10 p.m., Siddharth Seth wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java, > > line 296 > > <https://reviews.apache.org/r/48186/diff/3/?file=1405398#file1405398line296> > > > > Don't think that's required, given that the entire event is being > > signed.
anything the reduces the surface is good... I'll keep the TODO for now. > On June 3, 2016, 7:10 p.m., Siddharth Seth wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java, > > line 362 > > <https://reviews.apache.org/r/48186/diff/3/?file=1405398#file1405398line362> > > > > Don't think this message is correct. There's nothing inside splitBytes > > other than the split (which unfortunately has a really large Hive > > configuration) First we build the signable thing, convert it into bytes (as we should), and put it inside SubmitWorkInfo. Then we serialize that into byte[] and put it into LlapInputSplit. Then we serialize that to return... I'll file a follow up > On June 3, 2016, 7:10 p.m., Siddharth Seth wrote: > > ql/src/java/org/apache/tez/dag/api/TaskSpecBuilder.java, line 66 > > <https://reviews.apache.org/r/48186/diff/3/?file=1405399#file1405399line66> > > > > Please elaborate ? (This is not a public Tez API). > > > > Should this function just be removed. Used only once - the usage can be > > replaced by vertex.getInputs The reason the original function existed was actually different.. .this method has package visibility in Tez. So, there's this util class that pretends to be in the same package (note the path). - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48186/#review136090 ----------------------------------------------------------- On June 2, 2016, 8:55 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48186/ > ----------------------------------------------------------- > > (Updated June 2, 2016, 8:55 p.m.) > > > Review request for hive and Siddharth Seth. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > llap-client/src/java/org/apache/hadoop/hive/llap/LlapInputSplit.java > 02aedfd > > llap-client/src/java/org/apache/hadoop/hive/llap/ext/LlapTaskUmbilicalExternalClient.java > 0edb1cd > llap-common/src/java/org/apache/hadoop/hive/llap/NotTezEventHelper.java > PRE-CREATION > llap-common/src/protobuf/LlapDaemonProtocol.proto 486ba0a > > llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java > 4306c22 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java > d439c07 > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapTaskReporter.java > dc4482e > > llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskRunnerCallable.java > 0d9882b > > llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorTestHelpers.java > 96d626a > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java > 54fc3af > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java > 140dbda > ql/src/java/org/apache/tez/dag/api/TaskSpecBuilder.java 6d31802 > > Diff: https://reviews.apache.org/r/48186/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
