----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48159/#review137561 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 365) <https://reviews.apache.org/r/48159/#comment202705> two nested synchornized-s on the same thing. Also nit: is it possible to have an object to sync on, rather than syncing on something with global visiblity metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java (line 2366) <https://reviews.apache.org/r/48159/#comment202706> hmm... metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java <https://reviews.apache.org/r/48159/#comment202708> looks like TP was removed from here. Intended? - Sergey Shelukhin On June 14, 2016, 5:06 a.m., Rajesh Balamohan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48159/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 5:06 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-13901 > https://issues.apache.org/jira/browse/HIVE-13901 > > > Repository: hive-git > > > Description > ------- > > Depending on FS, creating external tables & adding partitions can be > expensive (e.g msck which adds all partitions). > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 285caa3 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > c0827ea > > Diff: https://reviews.apache.org/r/48159/diff/ > > > Testing > ------- > > > Thanks, > > Rajesh Balamohan > >
