> On 6月 15, 2016, 8:10 a.m., Sergey Shelukhin wrote: > > ql/src/test/queries/clientnegative/compare_double_bigint_between.q, line 1 > > <https://reviews.apache.org/r/48656/diff/1/?file=1417174#file1417174line1> > > > > this should not be necessary in all these files; the strict check for > > compares is on by default (or should be, if it's not). mapred.mode is > > deprecated.
Removed `set hive.mapred.mode=strict;` line. However, the strict check for compares is *off* by deafult. I changed the default value of `hive.mapred.mode` to `null` to make `hive.strict.checks.type.safety` is correctly referenced. - Takuma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48656/#review137612 ----------------------------------------------------------- On 6月 20, 2016, 6:31 p.m., Takuma Wakamori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48656/ > ----------------------------------------------------------- > > (Updated 6月 20, 2016, 6:31 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-13958: Support prohibiting string to decimal auto-casts. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 1e0ffa48f343ee11d78ae3a1de9f05ef4fee8eb0 > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java > aef46da4564808fd2c17fdd0a1cab442366587a3 > ql/src/test/queries/clientnegative/compare_double_bigint.q > 8ee4b277cbf729e6134e8f10dc6c76d1e4cd3482 > ql/src/test/queries/clientnegative/compare_double_bigint_between.q > PRE-CREATION > ql/src/test/queries/clientnegative/compare_double_bigint_in.q PRE-CREATION > ql/src/test/queries/clientnegative/compare_string_bigint.q > 810f65d4d2b448b99cdb8907c016e36b1d9e276e > ql/src/test/queries/clientnegative/compare_string_bigint_between.q > PRE-CREATION > ql/src/test/queries/clientnegative/compare_string_bigint_in.q PRE-CREATION > ql/src/test/results/clientnegative/compare_double_bigint_between.q.out > PRE-CREATION > ql/src/test/results/clientnegative/compare_double_bigint_in.q.out > PRE-CREATION > ql/src/test/results/clientnegative/compare_string_bigint_between.q.out > PRE-CREATION > ql/src/test/results/clientnegative/compare_string_bigint_in.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/48656/diff/ > > > Testing > ------- > > > Thanks, > > Takuma Wakamori > >
