> On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote: > >
I modified some codes in the latest patch. > On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 57 > > <https://reviews.apache.org/r/40867/diff/10/?file=1419433#file1419433line57> > > > > Use ReflectionUtils that exists within Hive ? > > The hadoop one is not a public class. > > I know that we use the hadoop one in other parts, but that is something > > we should move away from. I fixed it to use Hive ReflectionUtils. > On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 536 > > <https://reviews.apache.org/r/40867/diff/10/?file=1419433#file1419433line536> > > > > Wouldn't it be more performant to use LazyBinarySimpleSerde ? Excuse me, what is LazyBinarySimpleSerde? > On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java, line 1972 > > <https://reviews.apache.org/r/40867/diff/10/?file=1419435#file1419435line1972> > > > > We should log if the bypass is kicking in or not , and the reason for > > disabling it. > > There are so many cases where it gets disabled, it would be hard to > > debug in a production environment what the reason is. I fixed it to log the reasons. Since I am not a native speaker of English, please let me know if my English expressions are mistaken. > On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote: > > service-rpc/if/TCLIService.thrift, line 277 > > <https://reviews.apache.org/r/40867/diff/10/?file=1419437#file1419437line277> > > > > There is already typeDesc, why do we need typeName It is to handle complex column types. typeDesc does not have enough infomation for complex column types. For example, "struct<int, string>" is regarded as "struct". On the other hand, typename has detailed infomation as is. - Takanobu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review138347 ----------------------------------------------------------- On 6月 21, 2016, 2:10 a.m., Takanobu Asanuma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40867/ > ----------------------------------------------------------- > > (Updated 6月 21, 2016, 2:10 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > This is a WIP patch for HIVE-11527 > > * I added a new configuration whose name is > hive.server2.webhdfs.bypass.enabled. The default is false. When this value is > true, clients use the bypass. > > * I still have not considered security such as Kerberos and SSL at present. > > * I have not implement Statement#setFetchSize for bypass yet. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1e0ffa4 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java > 84644d1 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java > 0c313a2 > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniMr.java > 637e51a > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 8ac040e > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 92fdbca > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 2263192 > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java dff1815 > service-rpc/if/TCLIService.thrift 5a9a785 > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.h d23b3cd > service-rpc/src/gen/thrift/gen-cpp/TCLIService_types.cpp 0f53cb2 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java > 31472c8 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java > 7101fa5 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java > 1aa3f94 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java > c6279dc > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java > 1eaeee6 > > service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java > 14d50ed > service-rpc/src/gen/thrift/gen-php/Types.php a6a257f > service-rpc/src/gen/thrift/gen-py/TCLIService/ttypes.py fcd330f > service-rpc/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb 71148a0 > service/src/java/org/apache/hive/service/cli/CLIService.java ed52b4a > service/src/java/org/apache/hive/service/cli/ColumnDescriptor.java bfd7135 > service/src/java/org/apache/hive/service/cli/operation/Operation.java > d48b92c > > service/src/java/org/apache/hive/service/cli/operation/OperationManager.java > 2f18231 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 3bf40eb > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 78ff388 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > 7341635 > service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java > 8bc3d94 > > Diff: https://reviews.apache.org/r/40867/diff/ > > > Testing > ------- > > I have tested few simple queries and they worked well. But I think there are > some problems for some queries. I'm going to test more queries and fix bugs. > I'm also going to add unit tests. > > > Thanks, > > Takanobu Asanuma > >
