> On June 28, 2016, 1:47 a.m., cheng xu wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java, line 153 > > <https://reviews.apache.org/r/49264/diff/1/?file=1431046#file1431046line153> > > > > Maybe we should put the `reloadableAuxJars` in the first place so that > > it will override the existing addedJars if one jar is added alread in > > addedJars. If we don't allow users to override the addedJars or auxJars, we > > could describe this limitation in the configuration. Any thoughts for this?
I thought about that before. But it's hard to know which one override which one I guess. If the use call "reload", it's expecting the jars from reloadableAuxJars; if "create function using jar", then probably the jar from addedJars. So probably just keep one order. How do you think? - Aihua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49264/#review139712 ----------------------------------------------------------- On June 27, 2016, 1:09 p.m., Aihua Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49264/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 1:09 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-14037: java.lang.ClassNotFoundException for the jar in > hive.reloadable.aux.jars.path in mapreduce > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 1d1306ff6395a0504085dda98e96c3951519f299 > common/src/java/org/apache/hive/common/util/HiveStringUtils.java > bba14e21696af93dbee78d5073d130d09ec4e81c > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > 528d663e701eaa13e2cd7da328973637457ff642 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java > 8a6499b3a42273b729991540ca7a07f6d5cd73e2 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java > a42c2e99fe62aac96c21e4c5590c1891c1ea529c > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java > 96c826b6fb245bf7286fad7d1275268ceac4dd78 > ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java > bb6a4e1e1ea63d48556dd88bd6e02f80a0adb261 > ql/src/test/queries/clientpositive/reloadJar.q PRE-CREATION > ql/src/test/results/clientpositive/reloadJar.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/49264/diff/ > > > Testing > ------- > > > Thanks, > > Aihua Xu > >
