----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49881/#review143246 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/SynchronizedMetaStoreClient.java (line 19) <https://reviews.apache.org/r/49881/#comment209025> Right place for this is o.a.h.h.metastore package. ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 1729) <https://reviews.apache.org/r/49881/#comment209026> Lets use different config name here. Overloading this one at too many places. ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 1736) <https://reviews.apache.org/r/49881/#comment209040> We should reduce scope of this try. Too wide currently. ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 1762) <https://reviews.apache.org/r/49881/#comment209038> This is going to retrieve every partitions in Table. This may be problematic for tables which already had large number of partitions. ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (line 1824) <https://reviews.apache.org/r/49881/#comment209041> If any of these fails we need to cancel other futures. - Ashutosh Chauhan On July 21, 2016, 10:15 a.m., Rajesh Balamohan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49881/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 10:15 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-14204 > https://issues.apache.org/jira/browse/HIVE-14204 > > > Repository: hive-git > > > Description > ------- > > Lots of time is spent in sequential fashion to load dynamic partitioned > dataset in driver side. > > E.g simple dynamic partitioned load as follows takes 300+ seconds > > INSERT INTO web_sales_test partition(ws_sold_date_sk) select * from > tpcds_bin_partitioned_orc_200.web_sales; > > Time taken to load dynamic partitions: 309.22 seconds > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbLockManager.java b4ae1d1 > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 7b0369d > > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/SynchronizedMetaStoreClient.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ef0bb3d > > Diff: https://reviews.apache.org/r/49881/diff/ > > > Testing > ------- > > > Thanks, > > Rajesh Balamohan > >
