-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50586/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-14329
https://issues.apache.org/jira/browse/HIVE-14329
Repository: hive-git
Description
-------
main fix is some added sorting logic to MetaDataFormatUtils
i've seen some STATS_ACCURATE / COLUMN_STATS related order changes too; in that
class:
* fix for StatsSetupConst#setBasicStatsState: failed to upgrade&set basic stats
status
* removed: inconsitency: StatsSetupConst#setColumnStatsState would put
lowercase colnames if record is new; original colnames during update/addition
i've choosed to be keep the column names **case sensitive**
* removed: upgrade-while-read from: StatsSetupConst#areBasicStatsUptoDate
i'm not sure but: ...would it make sense to use jackson/ObjectMapper to parse
the params into a pojo; which then can be used more easily to read/write
colstats and other metadata like it more easily - i haven't looked into it; how
complicated would this be...
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 01e6010
common/src/test/org/apache/hadoop/hive/common/TestStatsSetupConst.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java
03803bb
Diff: https://reviews.apache.org/r/50586/diff/
Testing
-------
waiting for 1st test run
Thanks,
Zoltan Haindrich
