> On July 27, 2016, 3:26 p.m., Aihua Xu wrote: > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFStringToMap.java, > > line 34 > > <https://reviews.apache.org/r/50503/diff/1/?file=1455163#file1455163line34> > > > > Please add @Test annotation for unit tests. > > Zoltan Haindrich wrote: > if you use @Test annotations then the extends TestCase is not neccessary > - if you remove it, you have a junit4 testcase! :) > to get back the assert functions add: > import static org.junit.Assert.*;
I fixed my test accordingly. Thanks a lot for the hint. :) > On July 27, 2016, 3:26 p.m., Aihua Xu wrote: > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFStringToMap.java, > > line 53 > > <https://reviews.apache.org/r/50503/diff/1/?file=1455163#file1455163line53> > > > > Please remove all those empty spaces in this file. :) > > Zoltan Haindrich wrote: > there's an eclipse formatter under hive/dev-support ; i think its > prepared to remove extra spaces too...might worth a look I imported the eclipse-styles.xml file to the formatters in Eclipse, i thought it would remove the extra spaces, but it seems it didn't. I will have a closer look on this, maybe i just missed something in the config. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50503/#review143738 ----------------------------------------------------------- On July 27, 2016, 2:51 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50503/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 2:51 p.m.) > > > Review request for hive, Aihua Xu and Sergio Pena. > > > Bugs: HIVE-12954 > https://issues.apache.org/jira/browse/HIVE-12954 > > > Repository: hive-git > > > Description > ------- > > HIVE-12954: NPE with str_to_map on null strings > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java > ed60fbf > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFStringToMap.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50503/diff/ > > > Testing > ------- > > Added new unit test for GenericUDFStringToMap, please see the patch for > details. > Also did manual testing. > > > Thanks, > > Marta Kuczora > >
