----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49882/#review144128 -----------------------------------------------------------
Hey Peter, Changes look good. One thing to note is that you may hit some conflicts when rebasing this change. As part of HIVE-12646 I modified the `DDLTask.escapeHiveCommand()` method, which is removed in this RB. The fix would just be to remove the semicolon entry from the `ESCAPE_HIVE_COMMAND` `CharSequenceTranslator` - Sahil Takiar On July 11, 2016, 1:43 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49882/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 1:43 p.m.) > > > Review request for hive, Aihua Xu, Sergio Pena, Szehon Ho, and Vihang > Karajgaonkar. > > > Bugs: HIVE-14146 > https://issues.apache.org/jira/browse/HIVE-14146 > > > Repository: hive-git > > > Description > ------- > > The patch contains: > - MetaDataFormatUtils changes - to escape the \n in index, and column > comments (table comments are already handled) > - TextMetaDataFormatter changes - to escape the \n in database comments > - DDLTask chages - to escape \n in show create table result > - New query test, to test the escaping > > > Diffs > ----- > > common/src/java/org/apache/hive/common/util/HiveStringUtils.java 72c3fa9 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java bb43950 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java > 03803bb > > ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java > 47d67b1 > ql/src/test/queries/clientpositive/escape_comments.q PRE-CREATION > ql/src/test/results/clientpositive/escape_comments.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/49882/diff/ > > > Testing > ------- > > New unit test and manually > > > Thanks, > > Peter Vary > >
