----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51334/ -----------------------------------------------------------
Review request for hive, Naveen Gangam, Peter Vary, Sergio Pena, and Szehon Ho. Bugs: HIVE-14404 https://issues.apache.org/jira/browse/HIVE-14404 Repository: hive-git Description ------- Changed the class which is used to generate the output for the formats 'csv2', 'tsv2' and 'dsv' not to use SuperCSV any more and support multiple characters as delimiter. The class implements the same escaping logic as it had with SuperCSV if the quoting is not disabled. Extended the TestBeeLineWithArgs tests with new test steps which are using multiple characters as delimiter. This review is a follow-up for the review 50896. Diffs ----- beeline/pom.xml dc89e81 beeline/src/java/org/apache/hive/beeline/BeeLine.java e0fa032 beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java e6e24b1 beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 66d9fd0 itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 49c1120 Diff: https://reviews.apache.org/r/51334/diff/ Testing ------- - Tested manually in BeeLine. - Extended the TestBeeLineWithArgs tests with new test steps which are using multiple characters as delimiter. Thanks, Marta Kuczora