----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review146830 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java (line 73) <https://reviews.apache.org/r/51435/#comment213555> Isn't hiddenSet.clear() redundant here? We just created it on line 71. common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java (line 96) <https://reviews.apache.org/r/51435/#comment213551> nit: Values omitted for security reason if present common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java (line 97) <https://reviews.apache.org/r/51435/#comment213552> Instead of String concatenation use .append (maybe even make use of the flow API) hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java (line 488) <https://reviews.apache.org/r/51435/#comment213553> nit: Use flow API for the last append call as well. LGTM. Thanks for the patch. - Barna Zsombor Klara On Aug. 25, 2016, 6:01 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51435/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 6:01 p.m.) > > > Review request for hive, Chaoyu Tang, Gabor Szadovszky, Sergio Pena, and > Barna Zsombor Klara. > > > Bugs: HIVE-14426 > https://issues.apache.org/jira/browse/HIVE-14426 > > > Repository: hive-git > > > Description > ------- > > Used HiveConf.stripHiddenConfigurations to remove sensitive information from > configuration dump. Had to refactor, so it could be applied to simple > Configuration objects too, like AppConfig. > > Used Utilities.maskIfPassword to remove sensitive information from property > dump > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 14a538b > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 073a978 > > hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java > 201e647 > > Diff: https://reviews.apache.org/r/51435/diff/ > > > Testing > ------- > > Manually - checked both > > > Thanks, > > Peter Vary > >
