----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51395/#review146881 -----------------------------------------------------------
LGTM. Thanks for the patch. - Gabor Szadovszky On Aug. 24, 2016, 11:32 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51395/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2016, 11:32 p.m.) > > > Review request for hive. > > > Bugs: HIVE-14626 > https://issues.apache.org/jira/browse/HIVE-14626 > > > Repository: hive-git > > > Description > ------- > > Truncate table/partition is implemented to clean the contents of > table/partiton directory using multi-threaded trashFiles instead of > deleting/recreating the directory, so the encryption level is preserved if > any. In addition, it supports the HDFS Trash. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a59b781 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 5f53aef > ql/src/test/queries/clientpositive/encryption_drop_partition.q 57dfabd > ql/src/test/queries/clientpositive/encryption_drop_table.q 2ae3c69 > > ql/src/test/results/clientpositive/encrypted/encryption_drop_partition.q.out > 2643006 > ql/src/test/results/clientpositive/encrypted/encryption_drop_table.q.out > c5007ee > > Diff: https://reviews.apache.org/r/51395/diff/ > > > Testing > ------- > > Manual tests > New ptests > precommit tests > > > Thanks, > > Chaoyu Tang > >
