> On Aug. 25, 2016, 11:47 p.m., Gabor Szadovszky wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java, > > line 412 > > <https://reviews.apache.org/r/51381/diff/1/?file=1483999#file1483999line412> > > > > Not sure what would be the maximum number of rows. Is int enough?
At first I thought that Integer should be enough to hold the number of transactions on a table/partition, but I'll defer to the better judgement of anyone with more experience in the transaction compaction implementation. > On Aug. 25, 2016, 11:47 p.m., Gabor Szadovszky wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java, > > line 384 > > <https://reviews.apache.org/r/51381/diff/1/?file=1483999#file1483999line384> > > > > Is an int enough for this sum of ints? At first I thought that Integer should be enough to hold the number of transactions on a table/partition, but I'll defer to the better judgement of anyone with more experience in the transaction compaction implementation. - Barna Zsombor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51381/#review146886 ----------------------------------------------------------- On Aug. 26, 2016, 12:12 a.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51381/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2016, 12:12 a.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > HIVE-14427: CompactionTxnHandler.markCleaned() can delete aborted txns > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java > 75a4d875562f9ec85d2d02e36526de8b1e0c4404 > > ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java > f513d0fa791f24da4ce6312df9923db692ef7129 > > Diff: https://reviews.apache.org/r/51381/diff/ > > > Testing > ------- > > > Thanks, > > Barna Zsombor Klara > >
