----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52079/#review149643 -----------------------------------------------------------
Ship it! Thanks for the patch. LGTM. - Gabor Szadovszky On Sept. 20, 2016, 10:37 a.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52079/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 10:37 a.m.) > > > Review request for hive, Gabor Szadovszky, Peter Vary, and Sergio Pena. > > > Repository: hive-git > > > Description > ------- > > HIVE-14753: Track the number of open/closed/abandoned sessions in HS2 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/metrics/LegacyMetrics.java > 9be9b50aa02ff88816eb92079eaff9afa3e1be90 > common/src/java/org/apache/hadoop/hive/common/metrics/common/Metrics.java > 4297233ed12a7d9a2fa03ac3204e8335c0aed821 > > common/src/java/org/apache/hadoop/hive/common/metrics/common/MetricsConstant.java > 9dc96f9c6412720a891b5c55e2074049c893d780 > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java > 4c433678bd62ea74b80babce9856681192deb25f > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/MetricVariableRatioGauge.java > PRE-CREATION > common/src/test/org/apache/hadoop/hive/common/metrics/MetricsTestUtils.java > 46676589e6656d0f13f1931bfe67a63dd1920042 > > common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestMetricVariableRatioGauge.java > PRE-CREATION > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 15bab0660fcb9a997d66f6ff0a5dbc0e39c37ae7 > > service/src/test/org/apache/hive/service/cli/session/TestSessionManagerMetrics.java > 5511c54ff431211f7f72deaa017c915b839dfb2a > > Diff: https://reviews.apache.org/r/52079/diff/ > > > Testing > ------- > > Ran the unit tests in the common and the ql subprojects. > Manually verified the metrics using the HS2 webui metric dump. > > > Thanks, > > Barna Zsombor Klara > >
