----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52111/ -----------------------------------------------------------
Review request for hive and cheng xu. Repository: hive-git Description ------- Currently, when you run insert command on beeline, it returns a message saying "No rows affected .." A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)" Diffs ----- jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 42d398d ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 4b60514 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java bb6ed84 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 408c92e service-rpc/if/TCLIService.thrift a4fa7b0 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TArrayTypeEntry.java 358e322 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBinaryColumn.java a869cee service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBoolColumn.java 9bb6366 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBoolValue.java 87b3070 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TByteColumn.java 68b3d3c service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TByteValue.java a3d5951 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java 6dba051 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIServiceConstants.java 930bed7 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelDelegationTokenReq.java a7d4e7d service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelDelegationTokenResp.java 611e92c service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelOperationReq.java 4076c57 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelOperationResp.java 7bcc765 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseOperationReq.java 47a6b83 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseOperationResp.java 0860a2b service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseSessionReq.java 43ee87f service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseSessionResp.java 38f82ac service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumn.java 3c09c6b service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java 31472c8 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnValue.java be99ce0 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TDoubleColumn.java f93c9b4 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TDoubleValue.java 5700355 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java 1f73cec service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java 7101fa5 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TFetchOrientation.java 159be45 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TFetchResultsReq.java 2c93339 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TFetchResultsResp.java 8f86cee service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetCatalogsReq.java b8a2ca6 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetCatalogsResp.java eeeac9a service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetColumnsReq.java ba80279 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetColumnsResp.java c68aac9 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetCrossReferenceReq.java 9729570 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetCrossReferenceResp.java 1bfe6d1 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetDelegationTokenReq.java e3e28c5 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetDelegationTokenResp.java 6ef2acb service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetFunctionsReq.java ad4f8a5 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetFunctionsResp.java ead37fb service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetInfoReq.java b319b70 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetInfoResp.java 9be810b service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetInfoType.java 5b219b6 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetInfoValue.java 6b0a68e service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusReq.java 84c64cd service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetOperationStatusResp.java b981368 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetPrimaryKeysReq.java 1bec9b5 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetPrimaryKeysResp.java 72d9507 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetResultSetMetadataReq.java b94d827 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetResultSetMetadataResp.java ae2021e service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetSchemasReq.java 17eed87 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetSchemasResp.java e5317f7 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTableTypesReq.java c027748 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTableTypesResp.java c6ce0d4 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesReq.java 1aa3f94 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTablesResp.java 0b7c382 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTypeInfoReq.java 2e0ec60 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetTypeInfoResp.java cc2910e service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/THandleIdentifier.java a3879d8 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TI16Column.java 3c44b60 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TI16Value.java 29fb4cb service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TI32Column.java 9834f1c service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TI32Value.java 8a69632 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TI64Column.java cd5ef2d service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TI64Value.java 393c0bd service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TMapTypeEntry.java 7ebc15c service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionReq.java 18937d9 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOpenSessionResp.java 0a3c121 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationHandle.java 9eaf2be service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationState.java 4390b4b service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TOperationType.java 08002ad service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TPrimitiveTypeEntry.java 910c909 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TProtocolVersion.java bce2a0c service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRenewDelegationTokenReq.java 8957ebc service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRenewDelegationTokenResp.java 6f5004c service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRow.java e95299d service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TRowSet.java da3d9d3 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TSessionHandle.java b5cb6e7 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TStatus.java 50f4531 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TStatusCode.java fbf1418 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TStringColumn.java c83a1fd service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TStringValue.java 13874e5 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TStructTypeEntry.java 6c2c4f5 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TTableSchema.java 007b160 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TTypeDesc.java 055a14d service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TTypeEntry.java 3dbed9d service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TTypeId.java a3735eb service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TTypeQualifierValue.java 0fa69c8 service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TTypeQualifiers.java f46d2ce service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TUnionTypeEntry.java d53f74c service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TUserDefinedTypeEntry.java b80c4dd service/src/java/org/apache/hive/service/cli/CLIService.java 662e55c service/src/java/org/apache/hive/service/cli/OperationStatus.java b0a26e3 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 2938338 Diff: https://reviews.apache.org/r/52111/diff/ Testing ------- Thanks, Ke Jia
