----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52743/ -----------------------------------------------------------
Review request for hive, Aihua Xu, Ashutosh Chauhan, Chaoyu Tang, and Szehon Ho. Repository: hive-git Description ------- jira https://issues.apache.org/jira/browse/HIVE-14927 * Extract inner class User and implement a proper builder for it. * Extract all common code to LdapAuthenticationTestCase class ** setting up the test case ** executing test case ** result validation Diffs ----- service/src/test/org/apache/hive/service/auth/TestLdapAtnProviderWithMiniDS.java 8c723cf service/src/test/org/apache/hive/service/auth/ldap/LdapAuthenticationTestCase.java PRE-CREATION service/src/test/org/apache/hive/service/auth/ldap/User.java PRE-CREATION Diff: https://reviews.apache.org/r/52743/diff/ Testing ------- Tests run: 126, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 04:02 min [INFO] Finished at: 2016-10-06T12:23:16-07:00 [INFO] Final Memory: 42M/1146M [INFO] ------------------------------------------------------------------------ Thanks, Illya Yalovyy
