> On Oct. 7, 2016, 2:57 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectMergeRule.java, > > line 59 > > <https://reviews.apache.org/r/51755/diff/1/?file=1494884#file1494884line59> > > > > Is this check not required on bottomIntersect?
We need this. if top is distinct, we can always merge whether bottom is distinct or not. if top is all, we can only merge if bottom is also all. that is to say, we should bail out if top is all and bottom is distinct. (I made some modifications.) > On Oct. 7, 2016, 2:57 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g, line 93 > > <https://reviews.apache.org/r/51755/diff/1/?file=1494889#file1494889line93> > > > > Good to call this TOK_EXCEPTALL since KW is except not minus. We have both of them... actually both except and minus are kws. anyway, im going to change it to except. - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51755/#review148788 ----------------------------------------------------------- On Sept. 9, 2016, 1:41 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51755/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 1:41 a.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-12765 > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelFactories.java > cf93ed8 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveIntersect.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectMergeRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveIntersectRewriteRule.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java > 9f5e733 > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java ff94160 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 7ceb005 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g df596ff > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9ba1865 > ql/src/java/org/apache/hadoop/hive/ql/parse/QBExpr.java cccf0f6 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 943d9d7 > ql/src/test/queries/clientpositive/intersect.q PRE-CREATION > ql/src/test/results/clientpositive/intersect.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/51755/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
