> On Oct. 18, 2016, 9:30 a.m., Barna Zsombor Klara wrote: > > Thank you for the patch Jianguo Tian. LGTM, pending tests. > > Hope you don't mind that I had a look as well.
Really appreciate for your review. I'll fix these problems and add tests. - Jianguo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52981/#review153059 ----------------------------------------------------------- On Oct. 18, 2016, 8:11 a.m., Jianguo Tian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52981/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 8:11 a.m.) > > > Review request for hive and cheng xu. > > > Bugs: HIVE-14679 > https://issues.apache.org/jira/browse/HIVE-14679 > > > Repository: hive-git > > > Description > ------- > > 1. Quoting should be enabled by default for csv2, tsv2 and dsv. > 2. Disabling quoting should be possible using a beeline argument. > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLine.java 79922d2 > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 57b9c46 > beeline/src/java/org/apache/hive/beeline/Commands.java 039e354 > beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java > 66d9fd0 > beeline/src/main/resources/BeeLine.properties ad79c01 > > Diff: https://reviews.apache.org/r/52981/diff/ > > > Testing > ------- > > > Thanks, > > Jianguo Tian > >
