Created a jira: HIVE-15051 <https://issues.apache.org/jira/browse/HIVE-15051> Test framework integration with findbugs, rat checks etc.
If there is someone who wants this task feel free to take it, otherwise I will do it myself. If you have any suggestions, ideas please comment. I will update my findings and results of my tests. Thanks, Peter > On Oct 25, 2016, at 9:03 AM, Lefty Leverenz <leftylever...@gmail.com> wrote: > >> >> @Prasanth - separate page on the wiki for 'Adding / modifying tests'. That >> can >> be discussed on the list, or modified directly. > > > Here's what the wiki has so far: > > - Tips for Adding New Tests > <https://cwiki.apache.org/confluence/display/Hive/TipsForAddingNewTests> > (written > in 2011) > - Developer Guide: Adding new unit tests > > <https://cwiki.apache.org/confluence/display/Hive/DeveloperGuide#DeveloperGuide-Addingnewunittests> > (outdated > instructions) > > -- Lefty > > > On Mon, Oct 24, 2016 at 4:49 PM, Siddharth Seth <ss...@apache.org> wrote: > >> There seems to be general consensus to follow this approach for commits, >> and waiting for pre-commit tests. I'm going to add this to the Hive Wiki. >> >> @Alan, On using Yetus - I don't really know much about it, so cannot >> comment. However, Hive does use a parallel test framework which generates >> reports, compiles hive via custom scripts, etc - I suspect that will >> complicate integration with a third party tool. Any one want to volunteer >> for the findbugs, javac error integration? >> >> @Prasanth - separate page on the wiki for 'Adding / modifying tests'. That >> can be discussed on the list, or modified directly. >> >> Thanks, >> Sid >> >> On Mon, Oct 17, 2016 at 12:07 PM, Sergey Shelukhin <ser...@hortonworks.com >>> >> wrote: >> >>> +1 >>> >>> On 16/10/13, 23:10, "Siddharth Seth" <ss...@apache.org> wrote: >>> >>>> There's been a lot of work to make the test runs faster, as well as more >>>> reliable via HIVE-14547, HIVE-13503, and several other jiras. Test >>>> runtimes >>>> are around the 1 hour mark, and going down. There were a few green >>>> pre-commit runs (after years?). At the same time, there's still some >> flaky >>>> tests. >>>> >>>> We really should try to keep the test runtimes down, as well as the >> number >>>> of failures - so that the pre-commit runs can provide useful >> information. >>>> >>>> I'm not sure what the current approach w.r.t precommit runs before a >>>> commit. What I've seen in other projects is that the pre-commit needs to >>>> run, and come back clean (mostly) before a commit goes in. Between what >>>> used to be 5 day wait times, and inconsistent runs - I don't think this >> is >>>> always followed in Hive. >>>> >>>> It'll be useful to start relying on pre-commit test results again. Given >>>> the flaky tests, I'd suggest the following >>>> 1. Pre-commit must be run on a patch before committing (with very few >>>> exceptions) >>>> 2. A green test run is ideal >>>> 3. In case there are failures - keep track of these as sub-jiras under a >>>> flaky test umbrella jira (Some under HIVE-14547 already) - to be >>>> eventually >>>> fixed. >>>> 4. Before committing - cite relevant jiras for a flaky test (create and >>>> cite if it doesn't already exist). >>>> >>>> This should help us build up a list of flaky tests over various runs, >>>> which >>>> will hopefully get fixed at some point. >>>> >>>> Thoughts? >>>> >>>> Thanks, >>>> Sid >>> >>> >>
