-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52912/#review155521
-----------------------------------------------------------




ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 294)
<https://reviews.apache.org/r/52912/#comment225510>

    I would rather put the new rewrite rule here for intervalLiteral. Here you 
can branch out, and say it can also match the new requirement. 
    for example, expr ... etc.



ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 347)
<https://reviews.apache.org/r/52912/#comment225509>

    Then "select date '2012-01-01' + 1 days from t;" can not be supported as 
there is no parenthese.


- pengcheng xiong


On Oct. 15, 2016, 9:27 p.m., Zoltan Haindrich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52912/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2016, 9:27 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-13557
>     https://issues.apache.org/jira/browse/HIVE-13557
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> * added intervalExpression
> * syntax: INTERVAL (c) DAY
> * added days/months/seconds/years
> * kept the existing (interval '8' days) as is
> * INTERVAL keyword usage is optional
> * moving this into an udf seemed like a good thing, this way: it may accept 
> column refs or expressions as input (sql2011)
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 
> 0dbbc1d6226330bcb8271abba8b2675adaeb6f0f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 
> 025ea10cda5b126f46226809884088caadc0a3d0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 
> 13f68796e4fe262098eaf6c5f09bc7f963d0f8cf 
>   
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInternalInterval.java
>  PRE-CREATION 
>   
> ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFInternalInterval.java
>  PRE-CREATION 
>   ql/src/test/queries/clientpositive/interval_alt.q PRE-CREATION 
>   ql/src/test/results/clientpositive/interval_alt.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52912/diff/
> 
> 
> Testing
> -------
> 
> * small unit test to check exceptions
> * added qtest
> 
> 
> Thanks,
> 
> Zoltan Haindrich
> 
>

Reply via email to