----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53800/#review155997 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java (line 72) <https://reviews.apache.org/r/53800/#comment226085> Don't reuse error code. Use next available. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2582) <https://reviews.apache.org/r/53800/#comment226264> This should check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin && ... ) ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2792) <https://reviews.apache.org/r/53800/#comment226263> This should also check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin) {...} ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2820) <https://reviews.apache.org/r/53800/#comment226261> This should also check for absence of outer & semi joins. if (joinTree.getNoSemiJoin() && joinTree.getNoOuterJoin && ... ) ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2869) <https://reviews.apache.org/r/53800/#comment226262> this also should check for absence of outer and semi join. ql/src/test/queries/clientpositive/join45.q (line 185) <https://reviews.apache.org/r/53800/#comment226269> Can you add test for mix of conjunction and disjunction. something like following SELECT * FROM t1 RIGHT OUTER JOIN t2 a ON (a.key = t1.key) JOIN t3 b ON (b.key = a.key or b.value = a.value and t2.c1 = t1.c3) JOIN t4 on (t4.key = a.key or t2.c1 = t4.c3 and t4.value = a.value) JOIN t5 on (t5.key = a.key or t2.c1 = t4.c3 and t5.value = 42) LIMIT 10; - Ashutosh Chauhan On Nov. 15, 2016, 11:18 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53800/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 11:18 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-15211 > https://issues.apache.org/jira/browse/HIVE-15211 > > > Repository: hive-git > > > Description > ------- > > HIVE-15211 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java > 97fcd55295a0642b41f2f428606f72c3dba90470 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/JoinCondTypeCheckProcFactory.java > 9128d81e59d5b7e074b70572e9c110b29a63908b > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > 78011c221dc128085ceba8773be21113bb78ac31 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 8f5542bbe09f11b75248879df41a8e7c5cc54d78 > ql/src/test/queries/clientnegative/join45.q PRE-CREATION > ql/src/test/queries/clientpositive/join45.q PRE-CREATION > ql/src/test/results/clientnegative/join45.q.out PRE-CREATION > ql/src/test/results/clientpositive/join45.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/53800/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
