> On Nov. 22, 2016, 9:30 p.m., Illya Yalovyy wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2953
> > <https://reviews.apache.org/r/53966/diff/2/?file=1568277#file1568277line2953>
> >
> > is "copy" part of the file name misleading? It is not actually a copy
> > of an original file.
Correct, but that's what the old code is using:
for (int counter = 1; !destFs.rename(srcP,destPath); counter++) {
destPath = new Path(destf, name + ("_copy_" + counter) + filetype);
}
The filename could be better, but I'm using the same one to fix the issue as I
will need to investigate more in the code to see if that does not affect
something.
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53966/#review156629
-----------------------------------------------------------
On Nov. 21, 2016, 11:54 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53966/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2016, 11:54 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-15199
> https://issues.apache.org/jira/browse/HIVE-15199
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The patch helps execute repeated INSERT INTO statements on S3 tables when the
> scratch directory is on S3.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/common/FileUtils.java
> 1d8c04160c35e48781b20f8e6e14760c19df9ca5
> itests/hive-blobstore/src/test/queries/clientpositive/insert_into.q
> 919ff7d9c7cb40062d68b876d6acbc8efb8a8cf1
> itests/hive-blobstore/src/test/results/clientpositive/insert_into.q.out
> c25d0c4eec6983b6869e2eba711b39ba91a4c6e0
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
> 61b8bd0ac40cffcd6dca0fc874940066bc0aeffe
>
> Diff: https://reviews.apache.org/r/53966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
