> On 2011-11-15 22:41:17, Carl Steinbach wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java, line 1232 > > <https://reviews.apache.org/r/2831/diff/3/?file=58368#file58368line1232> > > > > Please don't move blocks of code around. It makes the diffs much harder > > to review. Please save cleanup/reorganization changes like this for > > refactoring patches.
I've moved the part because it was in the middle of inner-class named Registry, but should be referenced by outer-class FunctionRegistry. I'll revise patch to minimize the difference. > On 2011-11-15 22:41:17, Carl Steinbach wrote: > > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java, line 41 > > <https://reviews.apache.org/r/2831/diff/3/?file=58372#file58372line41> > > > > Please prefix boolean variable names with "is", e.g. "isTemporary". Will be backed-out with other modifications. > On 2011-11-15 22:41:17, Carl Steinbach wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g, line 1004 > > <https://reviews.apache.org/r/2831/diff/3/?file=58371#file58371line1004> > > > > Since we don't yet have the security mechanism in place to handle > > global non-temporary functions, I think we should leave the grammar > > unchanged and continue to require that the user specify the "TEMPORARY" > > keyword. Please back out this change, along with the modifications to > > CreateFuncDesc and DropFuncDesc. It was requested thing to us to register functions by admin authority. I should keep this part as a in-house patch. - Navis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2831/#review3281 ----------------------------------------------------------- On 2011-11-15 07:06:04, Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2831/ > ----------------------------------------------------------- > > (Updated 2011-11-15 07:06:04) > > > Review request for hive and Carl Steinbach. > > > Summary > ------- > > Extension from HIVE-2503 for function registry. > > > This addresses bug HIVE-2573. > https://issues.apache.org/jira/browse/HIVE-2573 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 4d4fce2 > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java 051095a > ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java 8a78f5b > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 07a4832 > ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 35d124b > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 197bc77 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 70b6f57 > ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java > f2b7018 > > Diff: https://reviews.apache.org/r/2831/diff > > > Testing > ------- > > > Thanks, > > Navis > >
