----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54451/#review158356 -----------------------------------------------------------
itests/hive-blobstore/src/test/queries/clientpositive/ctas.q (line 12) <https://reviews.apache.org/r/54451/#comment229122> Can we add SELECT queries to verify the data was correctly copied? Same for the rest of CTAS statements. itests/hive-blobstore/src/test/queries/clientpositive/ctas.q (line 25) <https://reviews.apache.org/r/54451/#comment229121> Should we delete the _dst tables too? ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java (line 2140) <https://reviews.apache.org/r/54451/#comment229124> Shouldn't we use the parent directory instead of the location? I think CTAS will do a rename() from the temp -> location once it finishes (test blobstores that specify only s3a://bucket/path or s3a://bucket). In this patch, the location will have a staging temp directory that when renamed will rename file per file because the staging is a subdirectory of the location. - Sergio Pena On Dec. 7, 2016, 1:59 a.m., Sahil Takiar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54451/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 1:59 a.m.) > > > Review request for hive, Sergio Pena and Yongzhi Chen. > > > Bugs: HIVE-15367 > https://issues.apache.org/jira/browse/HIVE-15367 > > > Repository: hive-git > > > Description > ------- > > CTAS with LOCATION should write temp data under location directory rather > than database location > > > Diffs > ----- > > itests/hive-blobstore/src/test/queries/clientpositive/ctas.q PRE-CREATION > itests/hive-blobstore/src/test/results/clientpositive/ctas.q.out > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c88dbc8 > ql/src/test/queries/clientpositive/ctas_uses_table_location.q PRE-CREATION > ql/src/test/results/clientpositive/ctas_uses_table_location.q.out > PRE-CREATION > ql/src/test/results/clientpositive/encrypted/encryption_ctas.q.out 5b503ac > > Diff: https://reviews.apache.org/r/54451/diff/ > > > Testing > ------- > > Added qtests for hive-blobstore and for qtest > > > Thanks, > > Sahil Takiar > >
