----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55194/#review160571 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java (line 208) <https://reviews.apache.org/r/55194/#comment231711> Should this be logged at INFO lvl? I understand that the hive query can still be executed just because we couldn't send the data to Yarn, but shouldn't it be at least a warning since something went wrong? ql/src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java (line 213) <https://reviews.apache.org/r/55194/#comment231712> Same as line 208. Should this be a warning instead? Thanks for the patch. LGTM, just minor nits. - Barna Zsombor Klara On Jan. 5, 2017, 2:28 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55194/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 2:28 a.m.) > > > Review request for hive. > > > Bugs: HIVE-15541 > https://issues.apache.org/jira/browse/HIVE-15541 > > > Repository: hive-git > > > Description > ------- > > Create the ATSHook executor with a bounded queue capacity > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 47db0c0 > ql/src/java/org/apache/hadoop/hive/ql/hooks/ATSHook.java 3651c9c > > Diff: https://reviews.apache.org/r/55194/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
