----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review160516 -----------------------------------------------------------
Looked over the first couple pages of the first patch. I'll take another look later. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2840) <https://reviews.apache.org/r/55156/#comment231653> This setting should probably default to false for the time being orc/src/java/org/apache/orc/impl/RecordReaderImpl.java (line 30) <https://reviews.apache.org/r/55156/#comment231654> Looks like this is an unnecessary change - remove this. ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeDynamicValueEvaluator.java (line 30) <https://reviews.apache.org/r/55156/#comment231743> Looks left over from cut and paste - can you change to "ExprNodeDynamicValueEvaluator" ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeDynamicValueEvaluator.java (line 50) <https://reviews.apache.org/r/55156/#comment231747> Can you move the call to setConf() up to the constructor so it is just done once? ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java (line 143) <https://reviews.apache.org/r/55156/#comment231762> This method takes in the extra conf parameter, but then doesn't do anything with it, it should be used by ExprNodeEvaluatorFactory.get() ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheWrapper.java (line 38) <https://reviews.apache.org/r/55156/#comment231778> leave this comment out ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java (line 49) <https://reviews.apache.org/r/55156/#comment231779> leave this comment out ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicValueRegistryTez.java (line 73) <https://reviews.apache.org/r/55156/#comment231780> Nit: add @Override ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java (line 186) <https://reviews.apache.org/r/55156/#comment231781> ReduceRecordProcessor is missing dynamicValueCache.release(), like MapRecordProcessor ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java (line 1185) <https://reviews.apache.org/r/55156/#comment231870> I think this change can be removed if we use the appropriate call to OperatorFactory.getAndMakeChild() during DynamicPartitionPruningOptimization. I'll try to play with this. ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java (line 2240) <https://reviews.apache.org/r/55156/#comment231871> same as above - Jason Dere On Jan. 4, 2017, 10:12 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55156/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2017, 10:12 p.m.) > > > Review request for hive, Gopal V, Gunther Hagleitner, Jason Dere, Prasanth_J, > and Rajesh Balamohan. > > > Bugs: HIVE-15269 > https://issues.apache.org/jira/browse/HIVE-15269 > > > Repository: hive-git > > > Description > ------- > > HIVE-15269 min-max runtime filtering. > The patch also contains the patch for HIVE-15270. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 47db0c0 > itests/src/test/resources/testconfiguration.properties 1cebc70 > orc/src/java/org/apache/orc/impl/RecordReaderImpl.java 975804b > orc/src/test/org/apache/orc/impl/TestRecordReaderImpl.java cdd62ac > pom.xml 376197e > ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractMapJoinOperator.java > 69ba4a2 > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java 940f2dd > ql/src/java/org/apache/hadoop/hive/ql/exec/DynamicValueRegistry.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeColumnEvaluator.java > 24c8281 > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantDefaultEvaluator.java > 89a75eb > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeConstantEvaluator.java > 4fe72a0 > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeDynamicValueEvaluator.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluator.java b8d6ab7 > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java > 0d03d8f > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorHead.java > 42685fb > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorRef.java > 0a6b66a > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeFieldEvaluator.java > ff32626 > > ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java > 221abd9 > ql/src/java/org/apache/hadoop/hive/ql/exec/FilterOperator.java bd0d28c > ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 46f0ecd > ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java > ac5331e > ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java 9718c48 > ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCache.java 440e0a1 > ql/src/java/org/apache/hadoop/hive/ql/exec/ObjectCacheWrapper.java 9768efa > ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 9049ddd > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java 008f8a4 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicValueRegistryTez.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 0141230 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/MapRecordProcessor.java > 955fa80 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ObjectCache.java 06dca00 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java > d80f201 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapJoinOperator.java > 0cb6c8a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSMBMapJoinOperator.java > 80b0a14 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > f6b6447 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DynamicValueVectorExpression.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/io/sarg/ConvertAstToSearchArg.java > 9d900e4 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/DynamicPartitionPruningOptimization.java > 26fcc45 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/FixedBucketPruningOptimizer.java > 9e9beb0 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/RedundantDynamicPruningConditionsRemoval.java > d9ce017 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > aa1e509 > ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java e2363eb > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 35f34da > ql/src/java/org/apache/hadoop/hive/ql/parse/RuntimeValuesInfo.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java e8b003e > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java cdb9e1b > ql/src/java/org/apache/hadoop/hive/ql/plan/BaseWork.java 13a0811 > ql/src/java/org/apache/hadoop/hive/ql/plan/DynamicValue.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicValueDesc.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestConvertAstToSearchArg.java > 93b50a6 > ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java > 8cbc26d > > ql/src/test/org/apache/hadoop/hive/ql/optimizer/physical/TestVectorizer.java > 3295372 > ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q > PRE-CREATION > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out > PRE-CREATION > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/LiteralDelegate.java > PRE-CREATION > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java > 8fda95c > > storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java > 10d8c51 > > Diff: https://reviews.apache.org/r/55156/diff/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
