----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55605/ -----------------------------------------------------------
(Updated Jan. 19, 2017, 1:45 a.m.) Review request for hive and Aihua Xu. Changes ------- Have to move setMaxSize into shutdown hook as the options were not ready at the previous code location. Tested manually and confirmed working. Bugs: HIVE-15166 https://issues.apache.org/jira/browse/HIVE-15166 Repository: hive-git Description ------- Currently Beeline does not provide an option to limit the max size for beeline history file, in the case that each query is very big, it will flood the history file and slow down beeline on start up and shutdown. Diffs (updated) ----- beeline/src/java/org/apache/hive/beeline/BeeLine.java 65818dd beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 9f330e3 beeline/src/main/resources/BeeLine.properties 141f0c6 beeline/src/test/org/apache/hive/beeline/TestBeelineArgParsing.java d73d374 Diff: https://reviews.apache.org/r/55605/diff/ Testing ------- Manual testing + a simple test case. Thanks, Eric Lin