----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55846/ -----------------------------------------------------------
(Updated Jan. 25, 2017, 1:12 p.m.) Review request for hive. Changes ------- Thank you for the review and for spotting the issues. I change the throwables to exceptions in the catch clauses. Repository: hive-git Description ------- HIVE-15604: Improve contents of qfile test output Diffs (updated) ----- itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestLocationQueries.java 06888467ec70eb1780e11969dafe2bff2c432d9d itests/util/src/main/java/org/apache/hadoop/hive/cli/control/AbstractCoreBlobstoreCliDriver.java 9c97c318ee89f598515d7b2e14f7f8184dc1119d itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreAccumuloCliDriver.java 3e4b3732cf49c1ac14baa58b65731f407f2b1dcd itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCliDriver.java a735346c062684eb6069565e7354b875cde44bd7 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreCompareCliDriver.java 71a02bca0b416c264beb00e95d2c3ab8da30b5c1 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseCliDriver.java 956a42d2711296061aa09f79596885af475ce6e6 itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreHBaseNegativeCliDriver.java 6225180a0735e41f5eee2c32e5b05c674e2edbdd itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreNegativeCliDriver.java 65b2ce71d3797823c6c14002384857cb2a61749a itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CorePerfCliDriver.java 8620cde37894aa5f15a4f7850c6f62c9ac8bf6d1 itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestProcessExecResult.java PRE-CREATION itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 1eaf7af5381a164f442a1094fb2543a08dc6c253 itests/util/src/main/java/org/apache/hadoop/hive/ql/parse/CoreParseNegative.java 8dba0bb9d5288240414a59f9468d3adae4dd8ef1 Diff: https://reviews.apache.org/r/55846/diff/ Testing ------- Ran qtests manually and checked the error messages. Checked that for diff failures we now have the output captured from the diff process in the error message of the failed test. Checkout how multiple tests, all with failures, look on the console to make sure that the results are still readeable/easy to follow. Thanks, Barna Zsombor Klara
