> On Jan. 27, 2017, 3:23 a.m., Sahil Takiar wrote: > > ql/src/test/org/apache/hadoop/hive/ql/exec/InputEstimatorTestClass.java, > > line 40 > > <https://reviews.apache.org/r/55994/diff/1/?file=1616672#file1616672line40> > > > > Is this necessary?
It was the only way I thought on testing the InputEstimator code path. There is no InputEstimator implementation on Hive, and the code path expects a class name instead of an object that can be mocked (see properties.setProperty(hive_metastoreConstants.META_TABLE_STORAGE, InputEstimatorTestClass.class.getName());) - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55994/#review163222 ----------------------------------------------------------- On Jan. 26, 2017, 8:09 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55994/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 8:09 p.m.) > > > Review request for hive, Mohit Sabharwal, Sahil Takiar, and Vihang > Karajgaonkar. > > > Bugs: HIVE-15736 > https://issues.apache.org/jira/browse/HIVE-15736 > > > Repository: hive-git > > > Description > ------- > > Added unit tests on TestUtilities to validate > - Single and multiple threads > - InputEstimator usage > - ContentSummaryInputFormat usage. > > It also fixed an issue with the InputEstimator scenario where the values > returned by the InputEstimator where overriden later by the correct > filesystem calls. > > An interesting thing (code commented while it is on review) is that when > executing the InputEstimator code path the line commented seems are not > needed. It might > be that the idea was to set some configurations to the jobConf, but the > jobConf was never passed as parameter to the estimate method. Please help me > verify this. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java > 68dd5e7247415dec1e353010ea34481c4f2fc6cd > ql/src/test/org/apache/hadoop/hive/ql/exec/InputEstimatorTestClass.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java > e444946e990d9adb90ce24837cfe4edcf5126d3a > > Diff: https://reviews.apache.org/r/55994/diff/ > > > Testing > ------- > > Waiting for tests HiveQA > > > Thanks, > > Sergio Pena > >
