> On Jan. 30, 2017, 4:53 p.m., Peter Vary wrote:
> > Hi Anthony,
> >
> > I am not too familiar with the ORC tables, but currently wokring on
> > enabling yetus on Hive.
> >
> > Yetus runs several checks which might help the work of the reviewers. Here
> > is what Yetus found with the checkstyle plugin:
> >
> > ./ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:3679:
> > addTableSchemaToConf(conf, tableScanOp.getSchemaEvolutionColumns(),
> > tableScanOp.getSchemaEvolutionColumnsTypes());: warning: Line is longer
> > than 100 characters (found 118).
> > ./ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:3688:
> > LOG.info(IOConstants.SCHEMA_EVOLUTION_COLUMNS + " and " +
> > IOConstants.SCHEMA_EVOLUTION_COLUMNS_TYPES +: warning: Line is longer than
> > 100 characters (found 108).
> > ./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:610:
> > pushFilters(jobConf, filterExpr, filterObj, serializedFilterObj,
> > serializedFilterExpr, tableScan.getSchema(),: warning: Line is longer than
> > 100 characters (found 113).
> > ./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:614:
> > public static void pushFilters(JobConf jobConf, ExprNodeGenericFuncDesc
> > filterExpr, Serializable filterObject,: warning: Line is longer than 100
> > characters (found 112).
> > ./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:614:
> > public static void pushFilters(JobConf jobConf, ExprNodeGenericFuncDesc
> > filterExpr, Serializable filterObject,:22: warning: More than 7 parameters
> > (found 8).
> > ./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:615:
> > String serializedFilterObj, String serializedFilterExpr, RowSchema
> > rowSchema, String schemaEvolutionColumns,: warning: Line is longer than 100
> > characters (found 114).
> > ./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:743:
> > pushFilters(jobConf, tableFilterExpr, filterObject, serializedFilterObj,
> > serializedFilterExpr, rowSchema,: warning: Line is longer than 100
> > characters (found 109).
> > ./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:747:
> > private Set<String> getAliasesForPath(Path splitPath, boolean nonNative,
> > Path splitPathWithNoSchema) {: warning: Line is longer than 100 characters
> > (found 104).
> > ./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:791:
> > private ExprNodeGenericFuncDesc buildTableFilterExpr(boolean noFilters,
> > List<ExprNodeGenericFuncDesc> filterExprs) {: warning: Line is longer than
> > 100 characters (found 118).
> > ./ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java:796:
> > if (tableFilterExpr == null ) {:38: warning: ')' is preceded with
> > whitespace.
> >
> > Running Findbugs, ASF header check, etc did not found any new problems.
> >
> > Thanks for the patch!
> >
> > Peter
Thanks for running Yetus on my patch, Peter! I addressed most of the warnings
(except the "More than 7 parameters" one) in my revision.
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55816/#review163528
-----------------------------------------------------------
On Jan. 31, 2017, 2:43 a.m., Anthony Hsu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55816/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 2:43 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-15680
> https://issues.apache.org/jira/browse/HIVE-15680
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15680: Incorrect results when hive.optimize.index.filter=true and same
> ORC table is referenced twice in query
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
> 68dd5e7247415dec1e353010ea34481c4f2fc6cd
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
> 51530ac16c92cc75d501bfcb573557754ba0c964
> ql/src/test/queries/clientpositive/orc_ppd_same_table_multiple_aliases.q
> PRE-CREATION
>
> ql/src/test/results/clientpositive/orc_ppd_same_table_multiple_aliases.q.out
> PRE-CREATION
> serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java
> 1354680584305bc7ea928526160f08fc9cbfd73e
>
> Diff: https://reviews.apache.org/r/55816/diff/
>
>
> Testing
> -------
>
> Added qtest.
>
>
> Thanks,
>
> Anthony Hsu
>
>
