----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56140/#review163997 -----------------------------------------------------------
ql/src/test/results/clientpositive/llap/cbo_limit.q.out (lines 69 - 70) <https://reviews.apache.org/r/56140/#comment235503> Previous result looks correct. New looks incorrect. ql/src/test/results/clientpositive/llap/cbo_rp_limit.q.out (line 69) <https://reviews.apache.org/r/56140/#comment235506> Result looks incorrect. ql/src/test/results/clientpositive/llap/explainuser_1.q.out (line 1434) <https://reviews.apache.org/r/56140/#comment235504> This likely is harmless change. But will be good to know whats the reason for this is. ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out <https://reviews.apache.org/r/56140/#comment235505> Do we know the reason for this change? Computing limit in map only job will be incorrect because many maps may get launched each outputing 2 rows making this incorrect. - Ashutosh Chauhan On Jan. 31, 2017, 10:44 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56140/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 10:44 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-15160 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e9bf3e4 > ql/src/test/queries/clientpositive/order_by_expr.q PRE-CREATION > ql/src/test/results/clientpositive/cp_sel.q.out 6300578 > ql/src/test/results/clientpositive/decimal_stats.q.out 5af58fb > ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out > 62f40cd > ql/src/test/results/clientpositive/llap/cbo_limit.q.out c582578 > ql/src/test/results/clientpositive/llap/cbo_rp_limit.q.out c582578 > ql/src/test/results/clientpositive/llap/explainuser_1.q.out b9489eb > ql/src/test/results/clientpositive/llap/vector_decimal_2.q.out 144356c > ql/src/test/results/clientpositive/llap/vector_decimal_round.q.out 8e7cd63 > ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out > 391c775 > ql/src/test/results/clientpositive/order_by_expr.q.out PRE-CREATION > ql/src/test/results/clientpositive/perf/query36.q.out b356628 > ql/src/test/results/clientpositive/perf/query70.q.out b4eaee6 > ql/src/test/results/clientpositive/perf/query86.q.out 6377c43 > ql/src/test/results/clientpositive/perf/query89.q.out 7bc8700 > ql/src/test/results/clientpositive/spark/cbo_limit.q.out c582578 > ql/src/test/results/clientpositive/vector_decimal_round.q.out 1e76ba2 > ql/src/test/results/clientpositive/vector_interval_arithmetic.q.out dd4b7d1 > > Diff: https://reviews.apache.org/r/56140/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
