> On Feb. 3, 2017, 1:16 a.m., Prasanth_J wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java, > > line 175 > > <https://reviews.apache.org/r/55977/diff/2/?file=1617247#file1617247line175> > > > > nit: typo VertorDeserializeOrcWriter > > Is the renaming happening elsewhere?
If I renamed it would be impossible to review. Will rename separately (filing a jira) > On Feb. 3, 2017, 1:16 a.m., Prasanth_J wrote: > > orc/src/java/org/apache/orc/impl/TreeReaderFactory.java, line 169 > > <https://reviews.apache.org/r/55977/diff/2/?file=1617249#file1617249line169> > > > > create ORC jira? ORC-140 > On Feb. 3, 2017, 1:16 a.m., Prasanth_J wrote: > > orc/src/java/org/apache/orc/impl/WriterImpl.java, line 2323 > > <https://reviews.apache.org/r/55977/diff/2/?file=1617250#file1617250line2323> > > > > seems not required. where is the dereference happening? I will make sure it will work after ORC upgrade by passing in a dummy MM, but I think this change is ok to keep for now. No compat problems when switching. I'll file an ORC jira, I bet it will be ORC-141 - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55977/#review163695 ----------------------------------------------------------- On Feb. 1, 2017, 3:34 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55977/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 3:34 a.m.) > > > Review request for hive, Gopal V and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a2ec1f0 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java > 85fae9a > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > d0e70d1 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java > 9ab26e6 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VertorDeserializeOrcWriter.java > 98fc9df > orc/src/java/org/apache/orc/impl/TreeReaderFactory.java 8b097ba > orc/src/java/org/apache/orc/impl/WriterImpl.java b1f3cfb > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 6281edd > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java > 0dba1a0 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java 1c5f0e6 > > storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java > b894c11e > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java > 552982c > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java > 6f090a1 > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/DecimalColumnVector.java > e4f8d82 > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.java > bd421f4 > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/IntervalDayTimeColumnVector.java > c4a6c0f > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java > 80d4731 > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/MultiValuedColumnVector.java > 1aeff83 > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/StructColumnVector.java > cf07bca > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.java > 28997a0 > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/UnionColumnVector.java > 0c61243 > > Diff: https://reviews.apache.org/r/55977/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
