----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56240/#review165015 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 79) <https://reviews.apache.org/r/56240/#comment236842> parenthese is not a word (or rather it's a word only in french.) can you please rename these function to "...inParenthesis"? ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 145) <https://reviews.apache.org/r/56240/#comment236843> nit: ws ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 316) <https://reviews.apache.org/r/56240/#comment236844> ws ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 372) <https://reviews.apache.org/r/56240/#comment236846> ws ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 378) <https://reviews.apache.org/r/56240/#comment236847> ws ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 381) <https://reviews.apache.org/r/56240/#comment236848> ws ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 526) <https://reviews.apache.org/r/56240/#comment236849> ws ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 527) <https://reviews.apache.org/r/56240/#comment236850> ws ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 534) <https://reviews.apache.org/r/56240/#comment236853> ws ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g (line 544) <https://reviews.apache.org/r/56240/#comment236852> ws ql/src/test/results/clientpositive/interval_alt.q.out (line 78) <https://reviews.apache.org/r/56240/#comment236855> this is confusing. i'll mention it on the jira itself also. ql/src/test/results/clientpositive/llap/vector_between_in.q.out (line 556) <https://reviews.apache.org/r/56240/#comment236856> i think this might be a problem, these don't seem to vectorize the same way any more. that could be a perf issue - Gunther Hagleitner On Feb. 8, 2017, 11:01 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56240/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 11:01 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-15388 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 1d8c3e0 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBSubQuery.java 311a34d > ql/src/test/queries/clientnegative/udf_in_2.q PRE-CREATION > ql/src/test/queries/clientpositive/interval_alt.q a4fbe9f > ql/src/test/queries/clientpositive/parenthese.q PRE-CREATION > ql/src/test/queries/clientpositive/udf_in.q a7ce3c6 > ql/src/test/queries/clientpositive/udf_notop.q dceab7e > ql/src/test/results/clientnegative/char_pad_convert_fail2.q.out 2d08fb3 > ql/src/test/results/clientnegative/invalid_select_expression.q.out 3650ca7 > ql/src/test/results/clientnegative/ptf_negative_DistributeByOrderBy.q.out > a0f3fe2 > ql/src/test/results/clientnegative/ptf_negative_PartitionBySortBy.q.out > a0f3fe2 > ql/src/test/results/clientnegative/ptf_window_boundaries.q.out 3808f2c > ql/src/test/results/clientnegative/ptf_window_boundaries2.q.out 3808f2c > ql/src/test/results/clientnegative/subquery_missing_from.q.out eaf7735 > ql/src/test/results/clientnegative/subquery_subquery_chain.q.out e661e1b > ql/src/test/results/clientnegative/subquery_with_or_cond.q.out 4a9cc45 > ql/src/test/results/clientnegative/udf_in.q.out 773230b > ql/src/test/results/clientnegative/udf_in_2.q.out PRE-CREATION > ql/src/test/results/clientpositive/interval_alt.q.out 04d5874 > ql/src/test/results/clientpositive/llap/vector_between_in.q.out 8a4383e > ql/src/test/results/clientpositive/parenthese.q.out PRE-CREATION > ql/src/test/results/clientpositive/perf/query14.q.out 21cabbc > ql/src/test/results/clientpositive/show_functions.q.out 3c9bb4a > ql/src/test/results/clientpositive/spark/vector_between_in.q.out 4de2eb6 > ql/src/test/results/clientpositive/udf_between.q.out 5b01554 > ql/src/test/results/clientpositive/udf_in.q.out da07f61 > ql/src/test/results/clientpositive/udf_notop.q.out 25483c7 > > Diff: https://reviews.apache.org/r/56240/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
