-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54065/
-----------------------------------------------------------
(Updated March 2, 2017, 3:32 p.m.)
Review request for hive, Aihua Xu, Chaoyu Tang, Peter Vary, and Sergio Pena.
Changes
-------
Fixed the patch according to the review.
Bugs: HIVE-15282
https://issues.apache.org/jira/browse/HIVE-15282
Repository: hive-git
Description
-------
Changed the way how the modification time is determined for partitions in the
DDLTask.alterIndex method to be the same as when the index staleness is
checked. Instead of using the modification date of the partition folder, go
through the files in the folder and use the highest modification time and save
it as index property. With this we can avoid the issue when the folder and the
file is created when the second turns. So the modification time of the folder
is in the previous second compared to the modification time of the file.
If the partition folder doesn't contain any files, then use the folder's
modification time, just as before.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 641e9d9
Diff: https://reviews.apache.org/r/54065/diff/2/
Changes: https://reviews.apache.org/r/54065/diff/1-2/
Testing
-------
Ran the index_auto_mult_tables_compact and index_auto_mult_tables q tests
multiple times, with hard-coded delay with which the test failure described in
HIVE-15282 could be reproduced. With the patch, the tests were always
successful.
Also ran all index related q tests.
Thanks,
Marta Kuczora
