> On March 14, 2017, 6:18 p.m., Sergey Shelukhin wrote: > > cli/src/java/org/apache/hadoop/hive/cli/RCFileCat.java > > Line 265 (original), 265 (patched) > > <https://reviews.apache.org/r/57586/diff/1/?file=1663203#file1663203line265> > > > > not sure if removing static from methods is needed... I usually prefer > > to ADD static to methods if they don't depend on an instance :) > > Non-binding
Given that "test" is changed to an instance variable, this method needs to be instance method as well. - Xuefu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57586/#review168921 ----------------------------------------------------------- On March 14, 2017, 4:32 a.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57586/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 4:32 a.m.) > > > Review request for hive. > > > Bugs: HIVE-16183 > https://issues.apache.org/jira/browse/HIVE-16183 > > > Repository: hive-git > > > Description > ------- > > Please see JIRA description > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 7e6846d > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java 181f0d2 > cli/src/java/org/apache/hadoop/hive/cli/RCFileCat.java f1806a0 > cli/src/test/org/apache/hadoop/hive/cli/TestRCFileCat.java 11ceb31 > common/src/java/org/apache/hadoop/hive/common/LogUtils.java c2a0d9a > common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java 926b4a6 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreSchemaInfo.java > 9c30ee7 > ql/src/java/org/apache/hadoop/hive/ql/exec/ArchiveUtils.java 6381a21 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 4ac25c2 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 6693134 > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java > 5b0c2bf > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CuckooSetBytes.java > 6383e8a > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTable.java > 9030e5f > ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java 6582cdd > ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndex.java a1408e9 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java 7727114 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 4995bdf > ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java d391164 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 369584b > ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanTask.java > 90b1dff > ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java 044d64c > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 0e67ea6 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/listbucketingpruner/ListBucketingPrunerUtils.java > 4d3e74e > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/GenMRSkewJoinProcessor.java > 93202c3 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 50eda15 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/VectorizerReason.java > e0a6198 > ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java > 36009bf > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > f175663 > ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java 01b5559 > ql/src/java/org/apache/hadoop/hive/ql/plan/AbstractVectorDesc.java e85a418 > ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 0b49294 > ql/src/java/org/apache/hadoop/hive/ql/plan/MapJoinDesc.java ca69697 > ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 9ae30ab > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorAppMasterEventDesc.java > 2e11321 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorFileSinkDesc.java 325ac91 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorFilterDesc.java 6feed84 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorGroupByDesc.java f8554e2 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorLimitDesc.java c9bc45a > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorMapJoinDesc.java 3aa65d3 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorMapJoinInfo.java 9429785 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPartitionDesc.java 4078c7d > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorReduceSinkDesc.java > 2eb44b8 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorReduceSinkInfo.java > 8c35415 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSMBJoinDesc.java 031f11e > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSelectDesc.java c2c9450 > > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSparkHashTableSinkDesc.java > 7fb59db > > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorSparkPartitionPruningSinkDesc.java > c0bc7e4 > ql/src/java/org/apache/hadoop/hive/ql/plan/VectorTableScanDesc.java 6e5ebe4 > ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java 145808b > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInternalInterval.java > fcf291a > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/CheckFastRowHashMap.java > 638ccc5 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/CommonFastHashTable.java > 90e8f33 > serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 6802a05 > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java > 88c3da9 > > serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/LazySimpleDeserializeRead.java > 3b35baf > serde/src/java/org/apache/hadoop/hive/serde2/lazy/fast/StringToDouble.java > f50b4fd > > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java > f4ac56f > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java > 14349fa > shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java 7270426 > > shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java > a58f1f2 > > shims/common/src/main/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerUtil.java > d972edb > shims/common/src/main/java/org/apache/hadoop/hive/shims/ShimLoader.java > 44f24b2 > > storage-api/src/java/org/apache/hadoop/hive/common/type/FastHiveDecimalImpl.java > 7a565dd > storage-api/src/java/org/apache/hadoop/hive/common/type/RandomTypeUtil.java > 8d950a2 > testutils/src/java/org/apache/hive/testutils/jdbc/HiveBurnInClient.java > 41ade5f > > > Diff: https://reviews.apache.org/r/57586/diff/1/ > > > Testing > ------- > > This relies on existing test cases. > > > Thanks, > > Xuefu Zhang > >
