----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57566/#review169037 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java Line 27 (original), 27 (patched) <https://reviews.apache.org/r/57566/#comment241359> I have a general question to understand the problem that you would like to resolve. I tried on current master. If there are two tables a and b and I rename a to b, I can see the error but a's table and column stats are not affected. If i change a's location to an existing one, its column and table stats disappeared. This is expected as we are now using the new location. Could u be talk more about how to reproduce the problem? Thanks. metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java Line 311 (original) <https://reviews.apache.org/r/57566/#comment241358> The deleted lines are dealing with the partition table. Is it safe to do so? - pengcheng xiong On March 15, 2017, 1:58 a.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57566/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 1:58 a.m.) > > > Review request for hive. > > > Bugs: HIVE-16189 > https://issues.apache.org/jira/browse/HIVE-16189 > > > Repository: hive-git > > > Description > ------- > > If the table rename does not succeed due to its failure in moving the data to > the new renamed table folder, the changes in TAB_COL_STATS are not rolled > back which leads to invalid column stats. > > This patch changes the order of metadata update and data move in alter table > rename operation, which makes it easier to roll back metadata changes when > moving data fails in rename a table. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > bae39ac > ql/src/test/queries/clientpositive/encryption_move_tbl.q 7a5de7b > ql/src/test/results/clientpositive/encrypted/encryption_move_tbl.q.out > cc363ac > > > Diff: https://reviews.apache.org/r/57566/diff/4/ > > > Testing > ------- > > > Thanks, > > Chaoyu Tang > >
