[ 
https://issues.apache.org/jira/browse/HIVE-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154733#comment-13154733
 ] 

Phabricator commented on HIVE-2561:
-----------------------------------

jsichi has commented on the revision "HIVE-2561 [jira] Add an annotation to 
UDFs to allow them to specify additional FILE/JAR resources necessary for 
execution".

INLINE COMMENTS
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:1091 The 
statefulness refers to the user-visible behavior of the function, not to its 
implementation.

  By declaring in_file to be stateful, you'd be preventing it from being used 
in the WHERE clause, and there's no reason for that restriction.
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java:41 
I'm not expecting any differences; if there were any it would probably have to 
do with how the filename is qualified.

  We have a "minimr" test mode; I'm not sure whether it exercises all the same 
code paths as the real thing with respect to added files.  Tests named in 
build-common.xml's minimr.query.files get run in this mode.

REVISION DETAIL
  https://reviews.facebook.net/D507

                
> Allow UDFs to specify additional FILE/JAR resources necessary for execution
> ---------------------------------------------------------------------------
>
>                 Key: HIVE-2561
>                 URL: https://issues.apache.org/jira/browse/HIVE-2561
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Jonathan Chang
>            Assignee: Jonathan Chang
>         Attachments: HIVE-2561.D507.1.patch
>
>
> Often times UDFs will have dependencies to external JARs/FILEs.  It makes 
> sense for these to be encoded by the UDF (rather than having the caller 
> remember the set of files that need to be ADDed).  Let's add an annotation to 
> UDFs which will cause these resources to be auto-added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to