----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58181/#review171761 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java Lines 355 (patched) <https://reviews.apache.org/r/58181/#comment244771> Do we need to register _is distinct from_ as well ? ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java Lines 719-726 (patched) <https://reviews.apache.org/r/58181/#comment244772> Won't we have this when user directly uses not <=> in query. How is that handled without this special map? - Ashutosh Chauhan On April 12, 2017, 12:14 a.m., Vineet Garg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58181/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 12:14 a.m.) > > > Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and > Pengcheng Xu. > > > Bugs: HIVE-15986 > https://issues.apache.org/jira/browse/HIVE-15986 > > > Repository: hive-git > > > Description > ------- > > This patch adds support for 'is distinct from' and 'is not distinct from'. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties fb85b9ece2 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > 85450c999f > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 8c4ee8a38b > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java > f979c1432e > ql/src/test/queries/clientpositive/is_distinct_from.q PRE-CREATION > ql/src/test/results/clientpositive/llap/is_distinct_from.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/58181/diff/5/ > > > Testing > ------- > > Added new tests > Pre-commit testing > > > Thanks, > > Vineet Garg > >
