----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58601/#review172833 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 2969 (patched) <https://reviews.apache.org/r/58601/#comment245864> I cannot comment on the file below. So commenting here. llap-server/runtest.sh unintentional addition? llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java Line 278 (original), 271 (patched) <https://reviews.apache.org/r/58601/#comment245964> any reason for >10? make it a static final value? llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java Line 292 (original), 281 (patched) <https://reviews.apache.org/r/58601/#comment245965> same like above. make attempt static final. llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java Lines 1773 (patched) <https://reviews.apache.org/r/58601/#comment245983> looks like INFO or DEBUG and not ERROR level. llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java Lines 1822 (patched) <https://reviews.apache.org/r/58601/#comment245982> nit: remove deadcode llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java Lines 65 (patched) <https://reviews.apache.org/r/58601/#comment245979> assuming someone will notify when the state has changed from FLAG_MOVING to something else. I can see that this loop tries to wait until state change but I don't see anyone actually notify using state.notify(). Looks like every 10ms we keep retrying and checking state instead of actually using notify on state change. llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java Lines 259 (patched) <https://reviews.apache.org/r/58601/#comment245980> this is where we probably want to notifyAll who are waiting on FLAG_MOVING state? llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java Lines 303 (patched) <https://reviews.apache.org/r/58601/#comment245981> better to add it here? caller doesn't seem to check. - Prasanth_J On April 21, 2017, 2:51 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58601/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 2:51 a.m.) > > > Review request for hive, Gopal V and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 771f588a38 > llap-server/runtest.sh PRE-CREATION > llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java > c049d2799c > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java > PRE-CREATION > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java > 5c0b6f3d07 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java > 7d5c1014fb > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java > 23796f65e8 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java > 761fd00443 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java > 3973c8a3aa > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java > cd5bc9b0b4 > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java > 51eb34e949 > > llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java > af7cf3d5f1 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java > 294fb2b41f > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 03bc3ced35 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java > 907200a6e3 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java > c9df7d94a0 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java > a6080e63fa > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocatorDefrag.java > PRE-CREATION > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java > e95f807679 > > llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java > 0cce624682 > pom.xml 5ec6befee6 > storage-api/src/java/org/apache/hadoop/hive/common/io/Allocator.java > 16b9713661 > storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java > e53b737910 > > > Diff: https://reviews.apache.org/r/58601/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
