> On May 8, 2017, 2:13 p.m., Yongzhi Chen wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Line 555 (original), 568 (patched) > > <https://reviews.apache.org/r/58992/diff/1/?file=1708349#file1708349line589> > > > > Can the transaction be properly rolled back with the incomplete state?
Yes, the move data and HMS transaction are different processes. If HMS transaction fails, it won't affect the data to be restored to the original location. - Chaoyu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58992/#review174165 ----------------------------------------------------------- On May 4, 2017, 2:19 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58992/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 2:19 p.m.) > > > Review request for hive. > > > Bugs: HIVE-16572 > https://issues.apache.org/jira/browse/HIVE-16572 > > > Repository: hive-git > > > Description > ------- > > This patch is to fix the issue in renaming a partition. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > d8af7a7 > ql/src/test/queries/clientpositive/alter_table_column_stats.q 39dfb0c > ql/src/test/queries/clientpositive/rename_external_partition_location.q > be93bd4 > ql/src/test/results/clientpositive/alter_table_column_stats.q.out 8739bfe > ql/src/test/results/clientpositive/rename_external_partition_location.q.out > 1670b4e > > > Diff: https://reviews.apache.org/r/58992/diff/1/ > > > Testing > ------- > > Manual tests > new qtests > > > Thanks, > > Chaoyu Tang > >
