----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58994/#review174219 -----------------------------------------------------------
Changes look good. +1 for me - Naveen Gangam On May 4, 2017, 9:57 p.m., Vihang Karajgaonkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58994/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 9:57 p.m.) > > > Review request for hive, Naveen Gangam, Sergio Pena, and Sahil Takiar. > > > Bugs: HIVE-16556 > https://issues.apache.org/jira/browse/HIVE-16556 > > > Repository: hive-git > > > Description > ------- > > HIVE-16556 : Modify schematool scripts to initialize and create > METASTORE_DB_PROPERTIES table > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestSchemaTool.java > 604c2345fcf04c877a8d257b9eef4610a58aea51 > metastore/scripts/upgrade/derby/041-HIVE-16556.derby.sql PRE-CREATION > metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql > 8877681e05f9d9ecb3bec5d8579772b386dc7f08 > metastore/scripts/upgrade/derby/upgrade-2.3.0-to-3.0.0.derby.sql > 3bba5235eb630e4ee5d14bf7f163dfb7166df0ed > metastore/scripts/upgrade/mssql/026-HIVE-16556.mssql.sql PRE-CREATION > metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql > 98682a83760f89aec441af3f6cb5ff03f5251496 > metastore/scripts/upgrade/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql > 94d18a34d37dea44a684242cbe1bdc5c3784d2e6 > metastore/scripts/upgrade/mysql/041-HIVE-16556.mysql.sql PRE-CREATION > metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql > 4db2f34159d6650fab4179d1478c6c91c72b5351 > metastore/scripts/upgrade/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql > e5d82e10160c2eab8571b3cd8f3078fbebcf3c5c > metastore/scripts/upgrade/oracle/041-HIVE-16556.oracle.sql PRE-CREATION > metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql > 7907c59f35a4575a614fdfd0419486156130ab23 > metastore/scripts/upgrade/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql > 31c4f5dfbd94fd52317ad0cd65517e09925767f7 > metastore/scripts/upgrade/postgres/040-HIVE-16556.postgres.sql PRE-CREATION > metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql > 49976d070d8a7ac825bb3920fa01f7d328aada9d > metastore/scripts/upgrade/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql > 2dd9bb9bfb607529f3ab9be4dccab34f26375e4f > > > Diff: https://reviews.apache.org/r/58994/diff/2/ > > > Testing > ------- > > 1. Used the testutils/metastore/metastore-upgrade-test.sh script to test > against postgres, mysql and derby database. > 2. Manually tested against Oracle and MSSQL databases > 3. Added unit-test to cover derby as well. > > > Thanks, > > Vihang Karajgaonkar > >
