> On May 23, 2017, 12:36 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java > > Line 206 (original), 210 (patched) > > <https://reviews.apache.org/r/59468/diff/1/?file=1727328#file1727328line210> > > > > I think we should call this optimizer here. This way a) its called > > after ReduceSinkDedup so that there is no chance that extra RS introduced > > by this optimization does not get removed and b) It won't violate any > > assumptions made by GroupbyOptimizer.
ColumnPruner will prune some of the columns, which violates the assumption that we make in the rule. Thus, we need to put it before Column Pruner. > On May 23, 2017, 12:36 a.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/metadataonly1.q.out > > Line 256 (original), 256-257 (patched) > > <https://reviews.apache.org/r/59468/diff/1/?file=1727335#file1727335line256> > > > > Earlier plan was better. When metadataonly optimizer can kick in that > > should. Yes, but i think the performance gain is minor as the table is empty. In NullScanTaskDispatcher, it expects that the GBY is distinct like. However, after our patch, we remove the distinct. - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59468/#review175736 ----------------------------------------------------------- On May 22, 2017, 10:31 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59468/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 10:31 p.m.) > > > Review request for hive, Ashutosh Chauhan and Gopal V. > > > Repository: hive-git > > > Description > ------- > > HIVE-16654 > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7dedd23591 > itests/src/test/resources/testconfiguration.properties e23ef6317f > ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd44fa > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/CountDistinctRewriteProc.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupByOptimizer.java > 3233157d8d > ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 7dace9076f > ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 38a9ef2af1 > ql/src/test/queries/clientpositive/count_dist_rewrite.q PRE-CREATION > ql/src/test/results/clientpositive/count_dist_rewrite.q.out PRE-CREATION > ql/src/test/results/clientpositive/groupby_sort_11.q.out 2b3bf4a07a > ql/src/test/results/clientpositive/groupby_sort_8.q.out 4faa0757cc > ql/src/test/results/clientpositive/llap/count_dist_rewrite.q.out > PRE-CREATION > ql/src/test/results/clientpositive/llap/metadataonly1.q.out 27218cf599 > ql/src/test/results/clientpositive/nullgroup4.q.out e5a8eeee14 > ql/src/test/results/clientpositive/perf/query16.q.out cf90c0c162 > ql/src/test/results/clientpositive/perf/query28.q.out 78129cf68b > ql/src/test/results/clientpositive/perf/query94.q.out 836b16bf9f > ql/src/test/results/clientpositive/perf/query95.q.out fa94d0842b > ql/src/test/results/clientpositive/spark/nullgroup4.q.out 24f0291dec > ql/src/test/results/clientpositive/udf_count.q.out f60ad0485e > ql/src/test/results/clientpositive/vector_empty_where.q.out b2dec6d7f6 > > > Diff: https://reviews.apache.org/r/59468/diff/1/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
